Optimize entity tracker effective range compute

Per TeaCon profiling results, getIndirectPassengers can take up to 50% tick time and most of it is stream.
This commit is contained in:
IzzelAliz 2022-05-03 10:53:23 +08:00
parent 8df52d958d
commit ee7fcdafc0
No known key found for this signature in database
GPG Key ID: EE50E123A11D8338
2 changed files with 47 additions and 0 deletions

View File

@ -0,0 +1,46 @@
package io.izzel.arclight.common.mixin.optimization.general;
import com.google.common.collect.ImmutableList;
import net.minecraft.world.entity.Entity;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Overwrite;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.stream.Stream;
@Mixin(Entity.class)
public abstract class EntityMixin_Optimize {
@Shadow public ImmutableList<Entity> passengers;
@Inject(method = "getIndirectPassengersStream", cancellable = true, at = @At("HEAD"))
private void arclight$emptyPassenger(CallbackInfoReturnable<Stream<Entity>> cir) {
if (this.passengers.isEmpty()) {
cir.setReturnValue(Stream.empty());
}
}
/**
* @author IzzelAliz
* @reason
*/
@Overwrite
public Iterable<Entity> getIndirectPassengers() {
if (this.passengers.isEmpty()) {
return Collections.emptyList();
} else {
var list = new ArrayList<Entity>();
for (var entity : this.passengers) {
list.add(entity);
list.addAll((Collection<? extends Entity>) entity.getIndirectPassengers());
}
return list;
}
}
}

View File

@ -8,6 +8,7 @@
"ClassInheritanceMultiMapMixin",
"ConnectionMixin_Optimize",
"EntityDataManagerMixin_Optimize",
"EntityMixin_Optimize",
"GoalMixin",
"MobMixin_Optimization",
"ResourceKeyMixin_Optimize",