Optimize command node add children

Reported by Dum4G. Commands#send took about 4 sec ordering this map, so use a sorted map instead of sorting it explicitly
This commit is contained in:
IzzelAliz 2021-02-05 13:39:24 +08:00
parent 7e67d95d4d
commit efc4df3c36
2 changed files with 33 additions and 0 deletions

View File

@ -0,0 +1,32 @@
package io.izzel.arclight.impl.mixin.optimization.stream;
import com.mojang.brigadier.Command;
import com.mojang.brigadier.RedirectModifier;
import com.mojang.brigadier.tree.CommandNode;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import java.util.Map;
import java.util.TreeMap;
import java.util.function.Predicate;
@Mixin(value = CommandNode.class, remap = false)
public class CommandNodeMixin_Optimization<S> {
// @formatter:off
@Shadow private Map<String, CommandNode<S>> children;
// @formatter:on
@Inject(method = "<init>", at = @At("RETURN"))
private void arclight$init(Command<S> command, Predicate<S> requirement, CommandNode<S> redirect, RedirectModifier<S> modifier, boolean forks, CallbackInfo ci) {
this.children = new TreeMap<>();
}
@Inject(method = "addChild", cancellable = true, at = @At(value = "INVOKE", target = "Ljava/util/Map;entrySet()Ljava/util/Set;"))
private void arclight$skipSort(CommandNode<S> node, CallbackInfo ci) {
ci.cancel();
}
}

View File

@ -4,6 +4,7 @@
"target": "@env(DEFAULT)",
"refmap": "mixins.arclight.impl.refmap.1_16.json",
"mixins": [
"CommandNodeMixin_Optimization",
"GoalSelectorMixin",
"ITaskQueue_PriorityMixin"
]